Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][12.0] add ability to remove current selection dichiarazione di intento in invoice #2437

Conversation

sergiocorato
Copy link
Contributor

@sergiocorato sergiocorato commented Sep 24, 2021

Descrizione del problema o della funzionalità: non è possibile rimuovere le dichiarazioni d'intento indicate nel campo nel tab Altre informazioni in fattura

Comportamento attuale prima di questa PR: non si possono rimuovere le dichiarazioni, anche se rimosse nel wizard

Comportamento desiderato dopo questa PR: si possono rimuovere le dichiarazioni andando a rimuoverle nel wizard

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@sergiocorato sergiocorato force-pushed the 12.0-fix-l10n_it_dichiarazione_intento-remove-selection branch 2 times, most recently from 46340fd to 0d136d0 Compare September 24, 2021 14:37
invoice.dichiarazione_intento_ids = [
(4, declaration.id)]
if self.declaration_ids:
invoice.dichiarazione_intento_ids = [(6, 0, self.declaration_ids.ids)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invoice.dichiarazione_intento_ids non può contenere dichiarazioni arrivate da qualcosa di diverso da self.declaration_ids?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possono essere impostate dalla righe fattura alla validazione, non ho trovato un metodo per far andare in conflitto le due cose.

@sergiocorato sergiocorato force-pushed the 12.0-fix-l10n_it_dichiarazione_intento-remove-selection branch from 0d136d0 to fe8ac02 Compare October 5, 2021 16:02
@matteoopenf
Copy link
Contributor

matteoopenf commented Jul 20, 2023

#3498 ho aperto una pr simile che fa si che vengono messe solo le righe selezionate e mostra quelle davvero usabili

@primes2h
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 12.0.

@OCA-git-bot OCA-git-bot force-pushed the 12.0-fix-l10n_it_dichiarazione_intento-remove-selection branch from fe8ac02 to 28a4dc4 Compare January 29, 2024 15:10
@primes2h
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 12.0.

@OCA-git-bot OCA-git-bot force-pushed the 12.0-fix-l10n_it_dichiarazione_intento-remove-selection branch from 28a4dc4 to 249380a Compare January 31, 2024 15:45
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@github-actions github-actions bot closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.0 missing issue stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants