[18.0][MIG] l10n_fr_siret + add glue module l10n_fr_siret_account #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile and fr translation
Prepare the migration of l10n_fr_naf_ape to v10
Start with good version names
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_siret/
Currently translated at 100.0% (23 of 23 strings) Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret/fr/
Currently translated at 100.0% (23 of 23 strings) Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret/
Currently translated at 100.0% (21 of 21 strings) Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-france-17.0/l10n-france-17.0-l10n_fr_siret Translate-URL: https://translation.odoo-community.org/projects/l10n-france-17-0/l10n-france-17-0-l10n_fr_siret/
Fixes OCA#38 l10n_fr_siret: unrequired dependency on account This is now possible because l10n_fr doesn't depend on account anymore and there is a new official module l10n_fr_account that acts as a glue module between l10n_fr and account.
Comment on lines
+11
to
+12
| siren = fields.Char(tracking=50) | ||
| nic = fields.Char(tracking=51) |
There was a problem hiding this comment.
I don't get why you redefine this two fields on the glue module. Why not in base module ?
also I'm not very familiar with this new tracking values. could you elaborate ?
Very nice modular move.
+1, indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v18, l10n_fr doesn't depend on account (only on base) and there is a glue module l10n_fr_account.
So, we should follow this movement in OCA and have l10n_fr_siret and l10n_fr_siret_account
Fixes #38 which was opened 9 years ago !!!
Small improvements: add siren/siret/nic in list view as optional=hide
This migration PR is an alternative to #578