[14.0][RFC] l10n_br_nfe: change methods names #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, @rvalyi, |
marcelsavegnago
changed the title
marcelsavegnago
requested review from
rvalyi,
renatonlima,
antoniospneto and
mileo
and removed request for
rvalyi
rvalyi
approved these changes
Nov 19, 2024
mileo
approved these changes
Nov 19, 2024
antoniospneto
approved these changes
Nov 20, 2024
|
/ocabot merge patch |
1 similar comment
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 1110360. Thanks a lot for contributing to OCA. ❤️ |
marcelsavegnago
deleted the
14.0-rfc-l10n_br_nfe-rename-fields-and-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
l10n_br_nfe/models/document.pyandl10n_br_nfe/tests/test_nfce.pyfiles to rename several compute methods for clarity and consistency. The most important changes include renaming the methods and updating the corresponding field definitions and test cases.Method Renaming for Clarity and Consistency:
l10n_br_nfe/models/document.py: Renamed_compute_emit_datato_compute_nfe_emit_dataand updated thenfe40_emitfield to use the new method name. [1] [2]l10n_br_nfe/models/document.py: Renamed_compute_dest_datato_compute_nfe_dest_dataand updated thenfe40_destfield to use the new method name. [1] [2]l10n_br_nfe/models/document.py: Renamed_compute_entrega_datato_compute_nfe_entrega_dataand updated thenfe40_entregafield to use the new method name. [1] [2]Test Case Updates:
l10n_br_nfe/tests/test_nfce.py: Updated the test casetest_compute_fiscal_document_fieldsto use the renamed methods_compute_nfe_entrega_dataand_compute_nfe_dest_data.