Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_br_mdfe: fix fields and methods names #3498

Merged

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Nov 19, 2024

This pull request includes changes to the l10n_br_mdfe/models/document.py file to standardize the naming convention for modal fields and methods. The changes mainly involve renaming identifiers to use a consistent mdfe_modal_* prefix.

Standardization of modal field and method names:

  • Renamed modal field identifiers to use the mdfe_modal_* prefix:

    • modal_aereo_id to mdfe_modal_aereo_id
    • modal_aquaviario_id to mdfe_modal_aquaviario_id
    • modal_ferroviario_id to mdfe_modal_ferroviario_id
    • modal_rodoviario_id to mdfe_modal_rodoviario_id
  • Updated method names to align with the new field naming convention:

    • _export_modal_aereo to _export_mdfe_modal_aereo
    • _export_modal_ferroviario to _export_mdfe_modal_ferroviario
    • _export_modal_aquaviario to _export_mdfe_modal_aquaviario
    • _export_modal_rodoviario to _export_mdfe_modal_rodoviario
  • Adjusted the method _get_modal_to_build to _get_mdfe_modal_to_build and updated its usage:

    • Modified the method signature and its references within the _build_attr method [1] [2]

@OCA-git-bot
Copy link
Contributor

Hi @mileo,
some modules you are maintaining are being modified, check this out!

@antoniospneto
Copy link
Contributor

/ocabot merge patch

1 similar comment
@marcelsavegnago
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3498-by-marcelsavegnago-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 09f5621 into OCA:14.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 732cc55. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-rfc-l10n_br_mdfe-rename-fields-and-methods branch November 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants