Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] intrastat_product_hscodes_import: 2023 CN codes #209

Merged
merged 2 commits into from
Nov 12, 2023
Merged

[IMP] intrastat_product_hscodes_import: 2023 CN codes #209

merged 2 commits into from
Nov 12, 2023

Conversation

luc-demeyer
Copy link
Contributor

Module l10n_be_intrastat_product, install wizard: 2023 CN codes.

@luc-demeyer
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-209-by-luc-demeyer-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 12, 2023
@OCA-git-bot
Merge PR #209 into 14.0
66107b7 
Signed-off-by luc-demeyer
@OCA-git-bot
Copy link
Contributor

@luc-demeyer your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-209-by-luc-demeyer-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@luc-demeyer
Copy link
Contributor Author

@sbidoul
pre-commit fails : AttributeError: 'EntryPoints' object has no attribute 'get'
It looks like the 14.0 branch of this repo is broken.
Can you have a look ?

@sbidoul
Copy link
Member

sbidoul commented Nov 12, 2023

It should be ok after #206 has landed.

@luc-demeyer
[IMP] intrastat_product_hscodes_import: 2023 CN codes
d4c66d8 
Module l10n_be_intrastat_product, install wizard: 2023 CN codes.
@luc-demeyer
[IMP] hscodes import: company always visible in install wizard
67a7973 
Module l10n_be_intrastat_product, install wizard:
The Company is a required field unchecking the 'Share Codes' flag.
User having access to the Configuration Wizards will now be able to set
the company field even if they do not belong to the multi-company usability
group.
@luc-demeyer luc-demeyer force-pushed the 14-intrastat_product_hscodes_import-2023 branch from 73c6f85 to 67a7973 Compare November 12, 2023 11:43
@luc-demeyer
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-209-by-luc-demeyer-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7112fb4 into OCA:14.0 Nov 12, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c77e61b. Thanks a lot for contributing to OCA. ❤️

@luc-demeyer luc-demeyer deleted the 14-intrastat_product_hscodes_import-2023 branch August 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luc-demeyer @OCA-git-bot @sbidoul