Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] geospatial_partner - error message on no partner with valid geom #361

Closed
wants to merge 41 commits into from

Conversation

wouitmil
Copy link

Added two fixes to avoid error message when no partners are encoded with a valid geo_point.

  1. The check extent !== infinite_extent wasn't working as it's not a recommended way to compare arrays in javascript.
  2. the filter in the right panel wasn't working if no partners are in the list

Added the geoengine view in the default contacts/resp_partner action

@wouitmil wouitmil marked this pull request as ready for review February 23, 2024 03:28
Hadrien Huvelle added 2 commits February 23, 2024 09:20
* writed the search tags end point
* writed the search partner end point
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM until pre-commit fix

@wouitmil wouitmil reopened this Feb 26, 2024
@wouitmil
Copy link
Author

wouitmil commented Feb 26, 2024

LGTM until pre-commit fix

I'll try to fix it. It may be caused by a working syntax (optional chaining) that is not accepted by this version of eslint. Is it possible that the version is too old?

I see here that it's should be fixed since eslint v7.9.0 (and I see that the version used is v8.24.0)

@wouitmil
Copy link
Author

LGTM until pre-commit fix

Fixed ;-)

@yvaucher yvaucher changed the title [FIX] geospatial_partner [16.0][FIX] geospatial_partner Feb 29, 2024
@yvaucher yvaucher changed the title [16.0][FIX] geospatial_partner [16.0][FIX] geospatial_partner - error message on no partner with valid geom Feb 29, 2024
@yvaucher
Copy link
Member

Can you improve the commit message [FIX] base_geoengine & geospatial_partner

Question to answer is: What do you fix in those modules?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@wouitmil wouitmil closed this Apr 10, 2024
@wouitmil wouitmil deleted the fix-geoengine-partner branch April 10, 2024 12:43
@wouitmil wouitmil restored the fix-geoengine-partner branch April 10, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants