Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [ADD] [FIX] fix map render with change timeout value #356

Closed
wants to merge 2 commits into from
Closed

[16.0] [ADD] [FIX] fix map render with change timeout value #356

wants to merge 2 commits into from

Conversation

igr-ok
Copy link

@igr-ok igr-ok commented Jan 19, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@legalsylvain
Copy link
Contributor

Hi. could you squash commits :

  • git rebase -i HEAD~3
  • s option on two last commits.
    thanks !

@Jordi-Buitrago Jordi-Buitrago mentioned this pull request Jan 22, 2024
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain
legalsylvain reviewed Jan 24, 2024
View reviewed changes
web_view_leaflet_map/i18n/fr.po Outdated
Comment on lines 57 to 62

#~ msgid "Activity"
#~ msgstr "Activité"

#~ msgid "Calendar"
#~ msgstr "Calendrier"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that addition looks weird. Why add commented translation ?
could you revert changes in fr.po ?
thanks !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changes only in map_renderer.js

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@github-actions github-actions bot closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@Jordi-Buitrago Jordi-Buitrago Jordi-Buitrago approved these changes

@navarrorico navarrorico navarrorico approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igr-ok @OCA-git-bot @legalsylvain @navarrorico @Jordi-Buitrago @weblate