Fix map render #355
Closed
Fix map render #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem with map render. Interval changed.
Update map_renderer.js
|
Hi @legalsylvain, |
There was a problem hiding this comment.
Hi @igr-ok. Thanks for your PR !
Question : This look quite high, and can generate delay for end user. Did you tried something smaller, like 100 ?
Technical : could you squash commits ?
regards.
|
Hi @legalsylvain, yes 500ms too much, 100 is OK i cheked; |
|
Hi @igr-ok. Thanks could you change the value and squash commits ? thanks ! |
100ms is better!
|
@legalsylvain, ok |
|
Hi @legalsylvain, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix map render - change timeout value.