Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [ADD] [FIX] Dialog to create gemoetry when geom field is empty in records panel #354

Closed
wants to merge 1 commit into from

Conversation

filipc96
Copy link

@filipc96 filipc96 commented Jan 18, 2024

While I was integrating the base_geoengine module in my module that adds maps and geometry to tasks and projects i noticed that when i click on a task that has no geometry, in the geoengine view record panel, an error appears.

In the base_geoengine_demo this error doesn't appear because the records are filtered only to show the ones with geometry, but I thought what if that was not the case like in my situation.

The error appeared because in the geoengine_renderer.esm.js the function onDisplayPopupRecord checked only if the feature is undefined and not for the situations when it is null or false. I changed it so that it checks for all falsy values.

Then because it caused nothing to happen when we click on a record with no geometry I went a step further and added a Conformation dialog that asks us if we want to add geometry to the record and if we do it opens an Edit Record dialog and if we don't it just closes the dialog.

Because an error also appeared when we clicked on the zoom to button I also added another check in the zoomOnFeature function to check if the feature exists when checking if the map_view exists.

image
image

@filipc96 filipc96 changed the title Dialog to create gemoetry when geom field is empty in records panel [16.0] [IMP] [FIX] Dialog to create gemoetry when geom field is empty in records panel Jan 18, 2024
@filipc96 filipc96 changed the title [16.0] [IMP] [FIX] Dialog to create gemoetry when geom field is empty in records panel [16.0] [ADD] [FIX] Dialog to create gemoetry when geom field is empty in records panel Jan 18, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant