-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP]dms: check for same storage #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch.
1e312e6
to
ab4fd7d
Compare
ab4fd7d
to
a86cc89
Compare
a86cc89
to
63cc5ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
/ocabot merge minor You can fw-port it to upper versions. |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 097a4ed. Thanks a lot for contributing to OCA. ❤️ |
Check if the storage is changed when both
storage_id
andparent_id
are passed to the write method