Add configurable support #264

PierrickBrun · 2017-10-10T14:32:26Z

Following the example of the bundle product, empty methods are created in order to be inherited.
That way the "flat" default system stays the same and the additional module will allow to import the configurable products in the Odoo format

import product attribute
import product attributes values
import product attribute lines
change product template
remove useless product templates
import product attribute prices
find a way to hide the principal product.product (linked to the magento configurable product) without removing the magento.product.product associated
example on the first line :
unit tests

oca-clabot · 2017-10-10T14:32:36Z

Hey @PierrickBrun, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@PierrickBrun (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

bealdav · 2017-10-10T15:32:08Z

Hi @gurneyalex
Pierrick is a new talentuous kid on the akretion block (but completely new in odoo) . Could you add it in the akretion team/cla ? Thanks.

bealdav · 2017-10-10T15:45:44Z

@guewen
A said Pierrick'll contribute on Magento for configurable products.
He have to learn a lot here but he dive in your code for its first job in Odoo. It seems he like it
We now have needs to decide what is the way to deal with configurable products.

Our plan is (please fix us):

import configurable as simple product : almost DONE
convert this simple product to a full set of product variants (with attributes)
inactive useless variant

The main question here is: step 2 and 3 should be synchro or deferred with a new job ?

cc @sebastienbeau

- import product attribute OK - import product attributes values OK - import product attribute lines OK - change product template OK - remove useless product templates WIP TODO : - too many unlink product.template jobs - find a way to hide the principal product.product (linked to the magento configurable product) without removing the magento.product.product associated - unit tests

guewen · 2017-10-23T07:20:56Z

The main question here is: step 2 and 3 should be synchro or deferred with a new job ?

As step 1 alone doesn't make sense without 2 and 3, it seems to me that it can be synchronous.

guewen

A few details spotted on quick eyeballing

connector_magento_configurable/models/inherit.py

connector_magento_configurable/models/product_attribute_line/importer.py

- switch to synchronous - problem : in magento, products created before a change in attribute prices don't change their price. In odoo they do -> can result in prices mismatch

PierrickBrun · 2017-10-26T13:01:16Z

Will start testing tomorrow, I think the functional perimeter is OK.

@guewen Do you have an idea how to hide the product.product without attributes ? (screenshot in the first post). If i disable it, the connector will stop updating the template.

Also, what is your opinion on the problem in product attribute prices ?
In magento, products created before a change in attribute prices don't change their price. In odoo they do -> can result in prices mismatch
Is an option to (de)activate it necessary or do we rely on sale order to handle this possible mismatch ?

guewen · 2017-11-03T15:14:05Z

@guewen Do you have an idea how to hide the product.product without attributes ? (screenshot in the first post). If i disable it, the connector will stop updating the template.

What is needed to update on the template? I'm really far to have the whole context, so I can be totally wrong, but I see these options:

use another 'active' field on the binding which overrides the template's one
consider even the inactive templates on the code that "update the template" (but I don't what you speak about)

Also, what is your opinion on the problem in product attribute prices ?
In magento, products created before a change in attribute prices don't change their price. In odoo they do -> can result in prices mismatch
Is an option to (de)activate it necessary or do we rely on sale order to handle this possible mismatch ?

I don't know what this problem is... In any way there must be a check in the sale order (it exists I think).

guewen

Thanks!

guewen

Oops, I reviewed only the last commit. What's the status, still WIP?

guewen

Looks good overall. Do you plan to add tests?

connector_magento_configurable/models/configurable.py

connector_magento_configurable/models/product_attribute_line/importer.py

…(for easier filtering)

…igurable parent

…or-magento into 10-configurable

PierrickBrun · 2018-02-06T14:45:25Z

Hi @guewen, I think everything is OK now, can you confirm ?

…ique template/attribute couple

… magento.product.template

connector_magento_configurable/models/product_product/importer.py

…e only at the creation

PierrickBrun force-pushed the 10-configurable branch from 089eb98 to ffe6c51 Compare October 10, 2017 15:45

PierrickBrun force-pushed the 10-configurable branch 12 times, most recently from af9c42d to 37664ea Compare October 16, 2017 14:20

PierrickBrun force-pushed the 10-configurable branch 2 times, most recently from 704d2e1 to 8663e37 Compare October 19, 2017 14:12

PierrickBrun force-pushed the 10-configurable branch from 8663e37 to 3224dc8 Compare October 20, 2017 15:26

guewen reviewed Oct 23, 2017

View reviewed changes

connector_magento_configurable/models/inherit.py Outdated Show resolved Hide resolved

connector_magento_configurable/models/product_attribute_line/importer.py Outdated Show resolved Hide resolved

PierrickBrun force-pushed the 10-configurable branch from a567d00 to b2b7163 Compare October 26, 2017 10:58

[IMP] product attribute prices

7792275

- switch to synchronous - problem : in magento, products created before a change in attribute prices don't change their price. In odoo they do -> can result in prices mismatch

PierrickBrun force-pushed the 10-configurable branch from b2b7163 to 7792275 Compare October 26, 2017 12:32

guewen approved these changes Nov 30, 2017

View reviewed changes

guewen requested changes Nov 30, 2017

View reviewed changes

guewen reviewed Nov 30, 2017

View reviewed changes

PierrickBrun added 8 commits February 6, 2018 14:33

[IMP] Add flag on product.product created from a configurable parent …

0c44ece

…(for easier filtering)

[IMP] adds possibility to search for inactive product.product as conf…

6732263

…igurable parent

add possibility to store attribute name/code in different fields easily

316db3c

fix use another field for attribute code

43555be

fix use another name field

3405c1d

[FIX] better handling of templates unlink

b897dd9

fix flake8

3e84eb9

Merge branch '10-configurable' of https://github.com/akretion/connect…

c992a55

…or-magento into 10-configurable

PierrickBrun added 2 commits February 7, 2018 11:01

[FIX] remove useless parameter

7f32947

[FIX] only unlink selected templates if they are not referenced

d46dbf7

PierrickBrun closed this Feb 19, 2018

PierrickBrun reopened this Feb 19, 2018

PierrickBrun and others added 4 commits February 26, 2018 16:37

[FIX] allowed the creation of several product.attribute.line for a un…

2882424

…ique template/attribute couple

[WIP] add magento.product.template

eb55905

[IMP] big refactoring : fixed conflicts with ERP and added support of…

641c13f

… magento.product.template

[FIX] product.attribute.lines not created

ea9f218

PierrickBrun force-pushed the 10-configurable branch from 219a8b0 to 5ede698 Compare March 12, 2018 11:31

[IMP] add magento fields on product_template view

c4ffd66

PierrickBrun force-pushed the 10-configurable branch from 5ede698 to c4ffd66 Compare March 12, 2018 11:37

[FIX] use magento.product.template in tests

b3051c4

PierrickBrun force-pushed the 10-configurable branch from 1beefbe to b3051c4 Compare March 13, 2018 10:22

PierrickBrun added 2 commits March 13, 2018 15:27

[FIX] tests

f115574

[FIX] small fixes

33f682c

PierrickBrun force-pushed the 10-configurable branch from 4a5ae9e to b8d2779 Compare March 15, 2018 13:47

sebastienbeau reviewed Mar 22, 2018

View reviewed changes

connector_magento_configurable/models/product_product/importer.py Outdated Show resolved Hide resolved

fix conflict

abc95a6

PierrickBrun force-pushed the 10-configurable branch from b8d2779 to abc95a6 Compare April 17, 2018 16:58

sebastienbeau added 2 commits April 18, 2018 11:18

[FIX] setting the variable "variant_managed_by_magento" should be don…

5d0bc1f

…e only at the creation

[IMP] add hack to not import description

6ddabd3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configurable support #264

Add configurable support #264

PierrickBrun commented Oct 10, 2017 •

edited

Loading

oca-clabot commented Oct 10, 2017

bealdav commented Oct 10, 2017

bealdav commented Oct 10, 2017 •

edited

Loading

guewen commented Oct 23, 2017

guewen left a comment

PierrickBrun commented Oct 26, 2017

guewen commented Nov 3, 2017

guewen left a comment

guewen left a comment

guewen left a comment

PierrickBrun commented Feb 6, 2018

Add configurable support #264

Are you sure you want to change the base?

Add configurable support #264

Conversation

PierrickBrun commented Oct 10, 2017 • edited Loading

oca-clabot commented Oct 10, 2017

bealdav commented Oct 10, 2017

bealdav commented Oct 10, 2017 • edited Loading

guewen commented Oct 23, 2017

guewen left a comment

Choose a reason for hiding this comment

PierrickBrun commented Oct 26, 2017

guewen commented Nov 3, 2017

guewen left a comment

Choose a reason for hiding this comment

guewen left a comment

Choose a reason for hiding this comment

guewen left a comment

Choose a reason for hiding this comment

PierrickBrun commented Feb 6, 2018

PierrickBrun commented Oct 10, 2017 •

edited

Loading

bealdav commented Oct 10, 2017 •

edited

Loading