[16.0] [ADD] sale_commission_margin: Decuct commission from margin

[luisDIXMIT]

This addon allows commissions to be deducted from the margin.

Because precomputed fields must depend on other precomputed fields, some computed fields in the commission module have been established as precomputed.

Issue #153

[OCA-git-bot]

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

I don't think these changes are correct.

[etobella]

This changes are necessary in order to avoid warnings. The problem comes from the fact that margin fields are pre-computed, then it needs pre-computed fields.

However, after checking Odoo documentation, we can use pre-compute to fill this fields, as they are generated in batch (they are lines). This is why we thought it was ok.

https://www.odoo.com/documentation/16.0/developer/reference/backend/orm.html?highlight=precompute

If you have a reason that we cannot see (it might be possible), we would be happy if you can enlighten us.

[pedrobaeza]

Then change this attribute in the module sale_commission_margin, not here. I prefer to not change it due to things like Precomputing a field can be counterproductive if the records of the given model are not created in batch

[etobella]

I understand your concerns, but the following sentences states:

Following the remark above, precomputed fields can be interesting on the lines of a one2many, which are usually created in batch by the ORM itself, provided that they are created by writing on the record that contains them

Usually, invoice_lines and sale order lines are generated with [(0, 0, {}), ...]. That means that they shouldn't be affected by the issue that you stated.

I prefer to do it directly on the base model in order to avoid future errors or incompatibilities (if we add fields that are not pre-computed, warnings will be raised if this module is installed). However, if there are not other options, we can do it as you suggest.

Also, it is recommended to change the priority of the view on sale.order in order to show the commission and then the margin. Should we do that directly on this new module or can we do it on sale_commission?

[pedrobaeza]

Uhm, I'm still a bit reluctant. We don't know how can it impact. If precompute mode was so good, then it would be enable by default. I still think that should be in the new module.

About the view priority switch, it can also be done on the new module. That way, you identify the whys of that changes.

[etobella]

It was made False because it only has sense in some models (mainly One2many fields) and it is problematic if we create items one by one.

Well, at this point I suggest to wait 24 hours if someone else makes its opinion, otherwise I will make the change directly in the module with the risks that it might imply.