[16.0] reference_type usability improvements #1332
Conversation
… invoice The Odoo payment_reference field is modifiable, so the reference type should be modifiable too.
sbidoul
force-pushed
the
16.0-reference_type-visibility-sbi
branch
from
914ebff
to
d04857e
Compare
…r bills So we can use structured communications on out payments too.
sbidoul
force-pushed
the
16.0-reference_type-visibility-sbi
branch
from
d04857e
to
31e0c3e
Compare
…ield Si it is more obvious that it relates to the payment_reference field
|
for the vendor bill case, the communication is provided by the supplier (structured or not), and the user only needs to fill in the given reference in the payment_reference field. There's no need for them to specify its type. |
| @@ -23,9 +23,9 @@ class AccountMove(models.Model): | |||
| # payment mode or company level | |||
| reference_type = fields.Selection( | |||
| selection=[("none", "Free Reference"), ("structured", "Structured Reference")], | |||
| readonly=True, | |||
There was a problem hiding this comment.
Consider adding reference_type to the _compute_payment_reference dependencies. We didn't need it before because the field was readonly after the invoice was posted. Now, since it can change for posted invoices, we need to trigger the payment reference recompute.
Hmm, but in Belgium (at least, but in the SEPA credit transfer format too), there is a concept of structured communication for outbound payments. So don't we need a way to specify that the communication is in a structured format that needs to be validated? This relates to OCA/l10n-belgium#204 |
|
@sbidoul I would love to discuss more about the business needs for structured communication for supplier invoices and customer invoices during the next OCA code sprint in Liège. I don't have a clear understanding of the details because it is not used in France. I'm sure we can both improve the usability and improve/simplify/cleanup the code! |
This PR makes the Reference Type