[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1465

mbcosta · 2023-05-25T21:49:45Z

Standard migration of stock_picking_invoicing to v16, #1250 some changes was necessary:

To avoid error in the Views with the Group parameter, I'm just create a simply method to check if the user has the group Account and make field Readonly if not, log of the error:

Field 'invoice_state' used in attrs ({'invisible': [('invoice_state', 'in', [False, 'none'])]}) is restricted to the group(s) account.group_account_invoice.

Removed get Price Unit for Invoice methods, because the field become compute in the account.move.line https://github.com/OCA/OCB/blob/16.0/addons/account/models/account_move_line.py#L330
Refund cases can has Local Origin Usage as Customer and Internal
Included onchange methods to the simulation the creation of the Invoice
In the cases of Reversal Moves is necessary link the account.move.lines with the stock.move related because the field picking_ids in account.move become compute https://github.com/OCA/stock-logistics-workflow/blob/16.0/stock_picking_invoice_link/models/account_move.py#L18

This PR should be replace #1449 because it's based in the v15 and by the tests I'm made with demo data the module are working as expect.

cc @renatonlima @rvalyi @jguenat

jguenat · 2023-05-25T22:06:22Z

Thanks @mbcosta you beat me to it I was planning to work on this next week :)
I'll review this more thoroughly Tuesday but here is my first comment:

"To avoid error in the Views with the Group parameter, I'm just create a simply method to check if the user has the group Account"

I think this is a little bit overkill and it seems that the standard "odoo way" of doing it is to simply add the field a second time with invisible="1". It mentioned in the comments of this PR odoo/odoo#95729

jguenat

LG thanks

jguenat · 2023-05-30T14:50:57Z

stock_picking_invoicing/models/stock_move.py

+    def _get_taxes(self, fiscal_position, inv_type):
+        """
+        Map product taxes based on given fiscal position
+        :param fiscal_position: account.fiscal.position recordset
+        :param inv_type: string
+        :return: account.tax recordset
+        """
+        product = self.mapped("product_id")
+        product.ensure_one()
+        if inv_type in ("out_invoice", "out_refund"):
+            taxes = product.taxes_id
+        else:
+            taxes = product.supplier_taxes_id
+        company_id = self.env.context.get("force_company", self.env.company.id)
+        my_taxes = taxes.filtered(lambda r: r.company_id.id == company_id)
+        return fiscal_position.map_tax(my_taxes)
+
+    @api.model
+    def _get_account(self, fiscal_position, account):
+        """
+        Map the given account with given fiscal position
+        :param fiscal_position: account.fiscal.position recordset
+        :param account: account.account recordset
+        :return: account.account recordset
+        """
+        return fiscal_position.map_account(account)


Seems it's not used anymore

…ddress

* Loading * Onchanges Etc

* Good Price with pricelist * Good Taxes * group works * Everything is filtered with company

* Get the correct taxes and account regarding Fiscal Position

mbcosta · 2023-09-08T22:05:42Z

About the last changes:

It's seems unnecessary inherit account.move.line objetc and _compute_price_unit method as I did before, tests are checking the cases of Price Unit informed by User in Picking or get Price from Sellers or from PriceList, the commit was removed
Despite there are methods to change Invoice State for Invoiced or Not Billable the buttons at some point in the other versions was removed, I didn't noticed before, so I put it back

And include onchage method to update the Invoice State when the field in the Picking are changed

Changed the product used in Demo Data to avoid error of Trancking Lot when MRP module are install, v14 PR [14.0][FIX] stock_picking_invoicing: demo product compatible with MRP module #1547 , but different from PR I choosed use a Product with BoM to, if necessary, test this case.

-Refactoring Tests by create methods to avoid duplicate code and, as said before, included tests for Price Unit cases.

mbcosta · 2023-09-14T20:27:00Z

We should avaliate the necessity of the Buttons "Set Invoiced" and "Set Not Billable" in Picking View. In my opinion the case of Not Billable is valide to allow users "fix" when a Picking was wrong marked "To Be Invoiced", I'm not certain about the case of "Invoiced", in which cases it will be use.

…ence true if value not get in vals

hildickethan

code+functional review, but I think it's more standard procedure to squash most of these migration commits unless they are adding new features
a86ecf5, e713989, 5ed7932, 473c119, b0d65e7, 273d4cb, 76f387f and 76f259b could all be squashed as generic migration
6af8bb2 and 573b5a2 i think are fine as is seperately as new features

adrip-s73 · 2023-11-16T10:24:18Z

stock_picking_invoicing/wizards/stock_invoice_onshipping.py

+        :param invoice: account.move
+        :return: dict
+        """
+        name = ", ".join(moves.mapped("name"))


hi, @mbcosta we found a problem when invoicing a picking with multiple moves with the same product it duplicates the name of the product in the invoice line and if we have the group = "partner_product" . We think that if changing this line to only get the first move's description if using the partner_prooduct option should avoid the issue.

…group(s)' when field has parameter Groups and are used in for defined an attribute/attrs in the Views and included the dependency of base_view_inheritance_extension module.

…voice consider the value of Product Pricelist or the Seller Price, changed Demo Data for tests.

…al=Hide), to allow users view or, if necessary, change the value.

…o the users be able setting Invoice State to Invoiced or Not Billable, also included onchange method to update this field in Move Lines when changed in Picking.

…d error of Tracking by Lot when MRP module are installed, but use a Product with BoM and Route Buy.

…licate code and included tests for the cases when Price Unit are Informed by User, Sellers and Pricelist.

…Line when Grouping Pickings by Partner/Product.

mbcosta · 2023-11-28T19:29:41Z

Thanks @hildickethan-S73 @adrip-s73 for your review, about the problems:

Squash 4 commits

commit 8c69b40 has a different author

Duplicate field Name/Label in Invoice Line in the case of Grouped Pickings by Partner/Product,

In the last commit I tried to fix it, I let separated commit to allow a backport, if necessary, or to made some change after reviews.

rvalyi

kudos for the hard work @mbcosta! ok for me, I think we can merge now as @jguenat approved and as you fixed the issue spotted 2 weeks ago.

rvalyi · 2023-11-28T20:29:14Z

/ocabot merge nobump

OCA-git-bot · 2023-11-28T20:29:32Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1465-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot · 2023-11-28T20:40:52Z

Congratulations, your PR was merged at 47cd67c. Thanks a lot for contributing to OCA. ❤️

mbcosta · 2023-11-28T22:23:59Z

thank all for review, if you find some problem or has a doubt about this module please mark me in the issue or PR, I have worked in this module for a while because it's important for Brazilian Localization so we need to keep it functional, but we also work to keep compatible with another countries.

jguenat · 2023-11-29T20:04:21Z

thank you @mbcosta for your work !

jguenat reviewed May 30, 2023

View reviewed changes

jguenat mentioned this pull request May 30, 2023

[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1449

Closed

mileo and others added 27 commits May 30, 2023 12:57

[REF] Renaming module stock_invoice_picking -> stock_picking_invoicing

47716d6

Fix module name in README

ec558dc

Add Bug Tracker to README

1d61457

[FIX] stock_picking_invoicing: README

69a41ed

[FIX] wrong bug tracker link

ef7a8a1

[FIX] using wrong partner for invoice, when delivering to a company a…

a4542e2

…ddress

OCA Transbot updated translations from Transifex

9412894

OCA Transbot updated translations from Transifex

41d0297

[UPD] prefix versions with 8.0

f22e80c

[MIG] Make modules uninstallable

23c125b

[FIX] remove en.po that was erroneously created by transbot

799411b

[MIG] Rename manifest files

7f91fe9

Initiate the migration

6f0d17d

Add the fields on the object and views

3803ff8

Implements the mechanics of views :

a3d479f

* Loading * Onchanges Etc

Views Improvements

d51d216

Business logic Ok :

302f23a

* Good Price with pricelist * Good Taxes * group works * Everything is filtered with company

Finalise business part :

311a0c6

* Get the correct taxes and account regarding Fiscal Position

Correction of bad Class usage

7e0989a

Add intercompany workflow

ecd40a2

better management of list_price

fa4cafd

OCA guidelines

4474914

OCA guidelines

4ad5909

Add dependencies and correct library from Travis

66026c0

Correct library from Travis

447c5ed

Correction https://travis-ci.org/OCA/account-invoicing/jobs/120042968

6c7a996

Add an option for forcing the invoice status in the wizard

3c57e2d

mbcosta force-pushed the 16.0-mig-stock_picking_invoicing branch from 9675abd to 01d3142 Compare September 8, 2023 21:07

mbcosta force-pushed the 16.0-mig-stock_picking_invoicing branch 2 times, most recently from 389903b to 76f259b Compare September 14, 2023 19:52

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023

[FIX] account_move_name_sequence: issue OCA#1465 vals get refund_sequ…

a04318c

…ence true if value not get in vals

hildickethan approved these changes Oct 16, 2023

View reviewed changes

adrip-s73 reviewed Nov 16, 2023

View reviewed changes

mbcosta and others added 9 commits November 28, 2023 15:43

[MIG] stock_picking_invoicing: Migration to 16.0

05b4d54

[MIG+IMP] stock_picking_invoicing: Avoid error 'is restricted to the …

8c69b40

…group(s)' when field has parameter Groups and are used in for defined an attribute/attrs in the Views and included the dependency of base_view_inheritance_extension module.

[REF+IMP] stock_picking_invoicing: Get Price Unit method to use in In…

56d70c5

…voice consider the value of Product Pricelist or the Seller Price, changed Demo Data for tests.

[REF] stock_picking_invoicing: Standard File Name for Views.

b817728

[IMP] stock_picking_invoicing: Included Price Unit in the View(option…

984bd67

…al=Hide), to allow users view or, if necessary, change the value.

[FIX+IMP] stock_picking_invoicing: Included Buttons in Picking view t…

a30e855

…o the users be able setting Invoice State to Invoiced or Not Billable, also included onchange method to update this field in Move Lines when changed in Picking.

[REF] stock_picking_invoicing: Demo Data, changed the Product to avoi…

419cede

…d error of Tracking by Lot when MRP module are installed, but use a Product with BoM and Route Buy.

[REF+IMP] stock_picking_invoicing: Tests, create methods to avoid dup…

3ae9762

…licate code and included tests for the cases when Price Unit are Informed by User, Sellers and Pricelist.

[REF] stock_picking_invoicing: Avoid duplicate Name/Label in Invoice …

95d4cd3

…Line when Grouping Pickings by Partner/Product.

mbcosta force-pushed the 16.0-mig-stock_picking_invoicing branch from 76f259b to 95d4cd3 Compare November 28, 2023 19:04

rvalyi approved these changes Nov 28, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 28, 2023

OCA-git-bot added the bot is merging ⏳ label Nov 28, 2023

OCA-git-bot merged commit aec3911 into OCA:16.0 Nov 28, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1465

[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1465

mbcosta commented May 25, 2023

jguenat commented May 25, 2023

jguenat left a comment

jguenat May 30, 2023

mbcosta commented Sep 8, 2023

mbcosta commented Sep 14, 2023

hildickethan left a comment

adrip-s73 Nov 16, 2023

mbcosta commented Nov 28, 2023

rvalyi left a comment

rvalyi commented Nov 28, 2023

OCA-git-bot commented Nov 28, 2023

OCA-git-bot commented Nov 28, 2023

mbcosta commented Nov 28, 2023

jguenat commented Nov 29, 2023

[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1465

[16.0][MIG] stock_picking_invoicing: Migration to 16.0 #1465

Conversation

mbcosta commented May 25, 2023

jguenat commented May 25, 2023

jguenat left a comment

Choose a reason for hiding this comment

jguenat May 30, 2023

Choose a reason for hiding this comment

mbcosta commented Sep 8, 2023

mbcosta commented Sep 14, 2023

hildickethan left a comment

Choose a reason for hiding this comment

adrip-s73 Nov 16, 2023

Choose a reason for hiding this comment

mbcosta commented Nov 28, 2023

rvalyi left a comment

Choose a reason for hiding this comment

rvalyi commented Nov 28, 2023

OCA-git-bot commented Nov 28, 2023

OCA-git-bot commented Nov 28, 2023

mbcosta commented Nov 28, 2023

jguenat commented Nov 29, 2023