Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_line_refund_to_invoice_qty: Migration to 16.0 #1461

Merged
merged 9 commits into from
Aug 7, 2023
Merged

[16.0][MIG] sale_line_refund_to_invoice_qty: Migration to 16.0 #1461

merged 9 commits into from
Aug 7, 2023

Conversation

JavierIniesta
Copy link

@JavierIniesta JavierIniesta commented May 19, 2023 •
edited
Loading

#1250
Add fix: #1383

@JavierIniesta JavierIniesta marked this pull request as draft May 19, 2023 11:12
@rafaelbn rafaelbn added this to the 16.0 milestone May 19, 2023
@JavierIniesta JavierIniesta force-pushed the 16.0-mig-sale_line_refund_to_invoice_qty branch from e357d5a to dd1a67f Compare May 23, 2023 05:56
@JavierIniesta JavierIniesta mentioned this pull request May 23, 2023
Open
64 tasks
@JavierIniesta JavierIniesta force-pushed the 16.0-mig-sale_line_refund_to_invoice_qty branch from dd1a67f to 252adfa Compare May 23, 2023 08:50
@JavierIniesta JavierIniesta force-pushed the 16.0-mig-sale_line_refund_to_invoice_qty branch 2 times, most recently from fbea4b5 to 1cea083 Compare June 1, 2023 07:46
@JavierIniesta JavierIniesta marked this pull request as ready for review June 21, 2023 11:59
@JavierIniesta JavierIniesta force-pushed the 16.0-mig-sale_line_refund_to_invoice_qty branch 3 times, most recently from 1034b59 to 0c9f2d0 Compare July 6, 2023 13:04
JordiMForgeFlow and others added 9 commits July 18, 2023 07:44
@JordiMForgeFlow
[ADD] sale_line_credit_note_invoiced_qty
9909ba6
@JordiMForgeFlow
[13.0][IMP]sale_line_refund_to_invoice_qty: add refund option explana…
7f84626 
…tion for usability and only display on credit notes
@AaronHForgeFlow
[IMP]sale_line_refund_to_invoice_qty: do not use negative booleans
3112d03
@GuillemCForgeFlow
[14.0][MIG]sale_line_refund_to_invoice_qty: Migration to 14.0
6e31475
@JasminSForgeFlow
[MIG] sale_line_refund_to_invoice_qty: Migration to 15.0
f99600d
@LoisRForgeFlow
[FIX] sale_line_refund_to_invoice_qty: do not change invoiced qty
43f6518 
when you mark a refund to not be reinvoiced, the invoice qty
should not be reduced, because it is already invoiced and you
won't invoice it again.
@ChrisOForgeFlow
[15.0][FIX] sale_line_refund_to_invoice_qty, fix default value on aml
33cea61
[IMP] sale_line_refund_to_invoice_qty: pre-commit stuff
632c52c
[MIG] sale_line_refund_to_invoice_qty: Migration to 16.0
4502e3c
@JavierIniesta JavierIniesta force-pushed the 16.0-mig-sale_line_refund_to_invoice_qty branch from 0c9f2d0 to 4502e3c Compare July 18, 2023 05:44
@AaronHForgeFlow
Copy link
Contributor

/ocabot migration sale_line_refund_to_invoice_qty

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-jmichaud
Copy link

@AaronHForgeFlow
Hello,
Who can merge this PR?
Thank you

@AaronHForgeFlow
Copy link
Contributor

@BT-jmichaud this LGTM but there is an open question in this PR: #1383 that is forward ported here. I prefer to wait until that question is solved or until @RodrigoBM reviews this one.

@AaronHForgeFlow
Copy link
Contributor

Well, as long as @RodrigoBM approved this one I think the question is solved.

1 similar comment
@AaronHForgeFlow
Copy link
Contributor

Well, as long as @RodrigoBM approved this one I think the question is solved.

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1461-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 14a9c5b into OCA:16.0 Aug 7, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e1a0aa5. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-sale_line_refund_to_invoice_qty branch August 7, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre ljsalvatierra-factorlibre approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.