Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] purchase_analytic_tag: Migration to 17.0 #715

Open
wants to merge 7 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] purchase_analytic_tag: Migration to 17.0 #715

wants to merge 7 commits into from

Conversation

AndreuOForgeFlow
Copy link

Standard migration

@ForgeFlow

@AndreuOForgeFlow AndreuOForgeFlow changed the title [17.0][MIG] purchase_analytic_tag [17.0][MIG] purchase_analytic_tag: Migration to 17.0 Nov 21, 2024
GuillemCForgeFlow
GuillemCForgeFlow approved these changes Nov 22, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional and code review 👍🏿

JordiMForgeFlow
JordiMForgeFlow approved these changes Nov 22, 2024
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍🏼

AaronHForgeFlow
AaronHForgeFlow reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM.

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

houssine78
houssine78 approved these changes Nov 26, 2024
View reviewed changes
Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houssine78
Copy link

@pedrobaeza this one can be merged. thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@houssine78 houssine78 houssine78 approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AndreuOForgeFlow @OCA-git-bot @houssine78 @AaronHForgeFlow @MiquelRForgeFlow @JordiMForgeFlow @GuillemCForgeFlow @victoralmau @mymage