-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_analytic: Migration to 18.0 #710
base: 18.0
Are you sure you want to change the base?
Conversation
… Stock analytic XML part is now migrated Add logo for generic modules
- migration point, put all the modules to not installable
This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.
Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README
Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/
(cherry picked from commit 9255622)
Currently translated at 100.0% (6 of 6 strings) Translation: account-analytic-14.0/account-analytic-14.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-stock_analytic/ca/
If we add extra move lines in stock pickings and wanted to set the analytic account on it, as the related move is not yet created, the behaviour of the related field is not wanted. So, store the analytic account on move line level too and add it in the values preparation hooks.
- Add validation on analytic distribution according to how it is done in other models (account.move.line, sale.order.line, etc.). - Update readme to reflect the current design. - Other cosmetic adjustments.
…ceipt picking view
Currently translated at 88.8% (8 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/nl/
Currently translated at 100.0% (9 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/es/
Currently translated at 100.0% (9 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/
Currently translated at 100.0% (10 of 10 strings) Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/it/
Needed to also rename method starting with double-underscrore to avoid Python method name mangling.
Currently translated at 100.0% (10 of 10 strings) Translation: account-analytic-17.0/account-analytic-17.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-stock_analytic/ca/
This commit fixes analytic_distribution not being passed from move to move line when updated after the move line is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
This PR has the |
@pedrobaeza this PR can be merged. thanks ! |
Module migrated to version 18.0
cc https://github.com/APSL 163677
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review