-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] account_analytic_line_split: add new module #681
base: 14.0
Are you sure you want to change the base?
[14.0][ADD] account_analytic_line_split: add new module #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[FUNCIONTAL REVIEW] [NEED TO CHECK]
-
The child_ids table is duplicated, maybe it's an effect if install other module: (account_analytic_wip). If the modules use same field it could be a problem in the future?
This field is created in analytic_activity_based_cost module on:
child_ids = fields.One2many(
I guess this module must to be included on dependency in manifest.py, is it make sense?
4fe0480
to
83cc187
Compare
83cc187
to
c440a86
Compare
This tree view is added with |
This module is in Alpha, when I tried to depend on it this error was triggered
And I think it doesn't make much sense to depend on this module because the purposes of the modules are different, I change the name of the fields to |
I also added unit tests, this pull request is ready for review now |
To review this pull request, you must uninstall |
ping @OCA/accounting-maintainers |
Ticket HT00788
cc: @marcelsavegnago @kaynnan @douglascstd