Updates to the JSON Schema - symlinks and root description #285
+32
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfiel
changed the title
jeremyfiel
commented
Nov 21, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "$id": "https://spec.openapis.org/arazzo/1.0/schema/2024-08-01", | |||
There was a problem hiding this comment.
we may also want to consider the $id WORK-IN-PROGRESS for schema development purposes. Overlay and OAS have included changing this to the deployment date with a build script on merge
ralfhandl
reviewed
Nov 22, 2024
There was a problem hiding this comment.
@frankkilcommins Should the JSON version be removed?
OAS only maintains the YAML representation and produces the JSON representation on-the-fly when publishing the schema.
There was a problem hiding this comment.
Arazzo doesn't have the full publishing process just yet
There was a problem hiding this comment.
Will be added with #290
ralfhandl
approved these changes
Nov 22, 2024
|
Should be merged after #289 and the resulting publishing PR in the OAS repo. |
ralfhandl
requested changes
Nov 25, 2024
it's been removed in #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$commentsymlinksThis PR assumes we will follow OAS and Overlay in providing
$commentmetadata in the schema which points to symlinks on the spec site.symlinks need to be updated on the main openapis.org site to support the changes here: