Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3s/ops): allow presigned url requests with up to 15 minutes clock skew #216

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Nugine
Copy link
Owner

@Nugine Nugine commented Nov 13, 2024

CC: @weisd

@Nugine
Copy link
Owner Author

Nugine commented Nov 13, 2024

@mergify queue

Copy link

mergify bot commented Nov 13, 2024

queue

🛑 This queue command has been cancelled by a dequeue command

@Nugine
Copy link
Owner Author

Nugine commented Nov 13, 2024

@Mergifyio dequeue

Copy link

mergify bot commented Nov 13, 2024

dequeue

✅ The pull request is not waiting to be queued anymore.

@Nugine
Copy link
Owner Author

Nugine commented Nov 13, 2024

@Mergifyio queue

Copy link

mergify bot commented Nov 13, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 207170f

Copy link

mergify bot commented Nov 13, 2024

This pull request, with head sha 207170f526c75a8190e8f9afadf961909fd01d34, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 207170f526c75a8190e8f9afadf961909fd01d34 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch fix/clock-skew, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 207170f into main Nov 13, 2024
14 checks passed
@Nugine Nugine deleted the fix/clock-skew branch November 13, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant