Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3UnwrappedXmlOutput of LocationConstraint #127

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

nomick
Copy link
Contributor

@nomick nomick commented Jan 17, 2024

The GetBucketLocation operation differs from other operations as it does not double the LocationConstraint XML tag. See https://smithy.io/2.0/aws/customizations/s3-customizations.html for details. Note that the example at https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html is also wrong, as the AWS-Client will also not accept it.

This patch fixes the output form

<LocationConstraint>
   <LocationConstraint>string</LocationConstraint>
</LocationConstraint>

to

<LocationConstraint>string</LocationConstraint>

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codegen/src/rust.rs Outdated Show resolved Hide resolved
codegen/src/xml.rs Show resolved Hide resolved
@nomick nomick force-pushed the fix-unwrapped-xml-output branch from d786ea1 to 0425aaa Compare January 21, 2024 14:12
@Nugine Nugine enabled auto-merge (squash) January 22, 2024 02:34
@Nugine Nugine merged commit 6a042ab into Nugine:main Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants