-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base e2e test #310
base: main
Are you sure you want to change the base?
feat: base e2e test #310
Conversation
Changes addressed previous FIXMEs, including: - Move DVN components around so it's more modular - Fix a minor bug on the executor, where the `provider` went out of scope and stopped listening. - Add some tests for the DVN.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Since the IDVNFeeLib is not working, it has been disabled from the DVN contract and now it provides a static fee. A simpler contract (has only the methods required by the interface, used for testing) has been added. All the contracts have been deployed (see `deployed_addresses.json inside the e2e folder)and Makefiles for automating the deployment have been added. OApps have been added to send a message and verify it has arrived on the destination chain.
481f38d
to
87464b6
Compare
Configure an OApp to use the DVN+Executors
Current Behavior
There's no end-to-end testing.
New Behavior
Added an OApp, with the configuration of the deployed DVNs.
Testing is WIP, running locally the necessary components. Will be dockerized.
This change is