Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SFFL title in docs #266

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix SFFL title in docs #266

merged 2 commits into from
Jul 2, 2024

Conversation

emlautarom1
Copy link
Contributor

Current Behavior

The current docs (https://nffl.nethermind.io) still show NEAR SFFL in the page title and navbar.

New Behavior

The title and navbar show NFFL rather than SFFL (fixes #255 (comment))

Breaking Changes

There should be no breaking changes.

Observations

We missed this on #255

@Hyodar
Copy link
Contributor

Hyodar commented Jul 2, 2024

LGTM, though IMO we should also replace NEAR SFFL -> NFFL and NEAR Fast Finality Layer -> Nuffle Fast Finality Layer

docs/docusaurus.config.js Outdated Show resolved Hide resolved
@mikhailUshakoff mikhailUshakoff dismissed their stale review July 2, 2024 11:33

A comment was missed.

@emlautarom1 emlautarom1 merged commit 1fd166e into main Jul 2, 2024
5 checks passed
@emlautarom1 emlautarom1 deleted the fix/docs-title branch July 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants