Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nffl demo examples #265

Merged
merged 13 commits into from
Oct 3, 2024
Merged

Nffl demo examples #265

merged 13 commits into from
Oct 3, 2024

Conversation

mikhailUshakoff
Copy link
Contributor

Current Behavior

Currently, there are no examples demonstrating how to interact with our protocol.

New Behavior

Implement simple scripts to:

  • Update the operator set
  • Update the state root
  • Get storage value

Breaking Changes

None

@Hyodar
Copy link
Contributor

Hyodar commented Jul 1, 2024

GJ! I know this is not yet open for reviews, just wanted to add something already.
Wdyt about making this into simple CLI programs? Should not be too hard, and we can specify some parameters as flags. I'm thinking like ./updateStateRoot.js --from arbitrum --to optimism --private-key <>. We can have a centralized config that reads the addresses from the scripts output folder. I think this would be the logical step here.

@Hyodar
Copy link
Contributor

Hyodar commented Jul 1, 2024

I'm a bit familiar with JS CLI tooling, so maybe it's more efficient if I get to it instead.

Copy link
Contributor

@Hyodar Hyodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small nit-picks, overall LGTM! I'll just ask you to check these comments and set up a small formatter (should be pretty easy) with an npm run format command - there are one or two formatting issues, so it's easier to just set one up.

demo-nffl-cli/.gitignore Outdated Show resolved Hide resolved
demo-nffl-cli/README.md Outdated Show resolved Hide resolved
demo-nffl-cli/README.md Outdated Show resolved Hide resolved
demo-nffl-cli/getStorageValue.js Outdated Show resolved Hide resolved
demo-nffl-cli/getStorageValue.js Outdated Show resolved Hide resolved
demo-nffl-cli/updateOperatorSet.js Outdated Show resolved Hide resolved
demo-nffl-cli/updateOperatorSet.js Outdated Show resolved Hide resolved
demo-nffl-cli/updateOperatorSet.js Outdated Show resolved Hide resolved
demo-nffl-cli/updateOperatorSet.js Outdated Show resolved Hide resolved
demo-nffl-cli/getStorageValue.js Outdated Show resolved Hide resolved
@serrrfirat
Copy link
Collaborator

fyi - I am turning this into a very lean typescript library so people can import it in their projects. WIll link the repo later.

@serrrfirat
Copy link
Collaborator

Shall we merge this? It would help applications who are integrating to have a base example. @Hyodar what do you think?

@Hyodar
Copy link
Contributor

Hyodar commented Aug 6, 2024

Hey! We could, let me take a look at this again. Still, if it's being moved to a library, IMO it's better to have this using the library already.

@serrrfirat
Copy link
Collaborator

Lets merge the example first, I'll create a PR with the library later on.

@Hyodar
Copy link
Contributor

Hyodar commented Aug 8, 2024

Alright, I'll do some changes there and will merge it soon

@Hyodar Hyodar merged commit b4a45eb into main Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants