-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nffl demo examples #265
Nffl demo examples #265
Conversation
GJ! I know this is not yet open for reviews, just wanted to add something already. |
I'm a bit familiar with JS CLI tooling, so maybe it's more efficient if I get to it instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small nit-picks, overall LGTM! I'll just ask you to check these comments and set up a small formatter (should be pretty easy) with an npm run format
command - there are one or two formatting issues, so it's easier to just set one up.
fyi - I am turning this into a very lean typescript library so people can import it in their projects. WIll link the repo later. |
955b782
to
223f614
Compare
Shall we merge this? It would help applications who are integrating to have a base example. @Hyodar what do you think? |
Hey! We could, let me take a look at this again. Still, if it's being moved to a library, IMO it's better to have this using the library already. |
Lets merge the example first, I'll create a PR with the library later on. |
Alright, I'll do some changes there and will merge it soon |
Current Behavior
Currently, there are no examples demonstrating how to interact with our protocol.
New Behavior
Implement simple scripts to:
Breaking Changes
None