Remove unnecessary scripts #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlautarom1
force-pushed
the
refactor/remove-dead-code
branch
from
0e1b7d8 to
43892f2
Compare
mikhailUshakoff
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Some scripts are no longer needed and should be removed (see #221)
New Behavior
Unused/unreferenced scripts are removed. The script
contracts/generate-go-bindings.shwas modified to ensure that prerequisites are met (runnpm ciat least once)Breaking Changes
There should be no breaking changes.
Observations
If you run the
contracts/generate-go-bindings.sh, the generated bindings differ from those in Git. The differences are localized tobind.MetaData.Binonly onSFFLServiceManagerandSFFLRegistryRollup. Maybe someone with Solidity knowledge can verify if this is an issue.