-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TTL to Operator RPC Client #259
Closed
Closed
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
0b420fb
Initial V2 impl for `rpc_client`
emlautarom1 27f918b
Add `retry later`
emlautarom1 ae9904e
Add `submittedAt` to actions
emlautarom1 9e1e849
Extract retry and retry later strategies
emlautarom1 890ac87
Add `retryIfRecentEnough`
emlautarom1 9a46a4f
Add `TestRetryLaterIfRecentEnough`
emlautarom1 4fef16a
Rename retry mechanism
emlautarom1 8e558f5
Test `retryAtMost`
emlautarom1 3950423
Store `retryPredicate` in struct member
emlautarom1 e0a82a0
Separate impl from tests
emlautarom1 6a7c004
Rename to `AggregatorRpcClient`
emlautarom1 6b0107d
Don't use `self`
emlautarom1 3fc60c6
Abstract `rpc.Client`
emlautarom1 658f752
Add `NewHTTPAggregatorRpcClient`
emlautarom1 17c134c
Add `AggregatorRpcClienter` interface
emlautarom1 ca0820a
Remove interface (single implementation)
emlautarom1 b64cb17
Rename client method names
emlautarom1 5eae2a1
Add `TestGetAggregatedCheckpointMessages`
emlautarom1 a0f833f
Make `GetAggregatedCheckpointMessages` blocking
emlautarom1 b5f5207
Replace event loop with blocking code
emlautarom1 24b027e
Add `Metricable` interface to `AggregatorRpcClient`
emlautarom1 cf09334
Use listener in `SendSignedCheckpointTaskResponseToAggregator`
emlautarom1 5ec7d28
Use listener in `SendSignedStateRootUpdateToAggregator`
emlautarom1 e576b5f
Use listener in `SendSignedOperatorSetUpdateToAggregator`
emlautarom1 22f5264
Add logs to `GetAggregatedCheckpointMessages`
emlautarom1 fefaa66
Add `RetryWithDelay`
emlautarom1 f3d197c
Rename parameter
emlautarom1 fc5665b
Add `RetryAnd` to compose rather than decorators
emlautarom1 f71d642
Add `DefaultRetryStrategy`
emlautarom1 6a6db7d
Start aggregator before operator
emlautarom1 28b0005
Replace original with v2
emlautarom1 7bcc7ff
Increase coverage by using different messages
emlautarom1 f4ee227
Ensure retry strategy is local to each method call
emlautarom1 9f3809e
Typo
emlautarom1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to discussion: how do we want to handle this dependency, in particular closing it?