Add Golang linter #251
Merged
Add Golang linter #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently no static analysis tools are being used as part of our build process (either local or CI).
New Behavior
As part of #215, we add golangci-lint as an additional dependency to lint Go files. The linter can be run using
make lint.Breaking Changes
This is not a breaking change since it adds a new Make target without affecting existing ones. Those who want to use the linter will need to add them to their dev enviroments
Observations
This PR also includes some fixes based on the linting results, mostly involving proper error handling (some errors were being ignored).
In the near future we want to: