Add cache-based duplicate log detection to SafeEthClient #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyodar
force-pushed
the
feat/improve-log-skipping
branch
from
1420d57 to
e978a5f
Compare
Hyodar
requested review from
taco-paco and
emlautarom1
and removed request for
taco-paco
Hyodar
force-pushed
the
feat/improve-log-skipping
branch
from
d8010ef to
837b176
Compare
Hyodar
force-pushed
the
feat/improve-log-skipping
branch
from
837b176 to
f47114d
Compare
emlautarom1
approved these changes
May 24, 2024
| @@ -187,7 +200,7 @@ func (c *SafeEthClient) SubscribeFilterLogs(ctx context.Context, q ethereum.Filt | |||
| rangeStartBlock = 0 | |||
| } | |||
|
|
|||
| fromBlock := max(lastBlock, rangeStartBlock) + 1 | |||
| fromBlock := max(lastBlock, rangeStartBlock+1) | |||
There was a problem hiding this comment.
More or less, this is related to this part of the description:
It also makes it so our log filtering starts from the last block, since we now can detect duplicate blocks - so if, e.g. there were 2 block emissions on lastBlock and we'd only gotten 1 before filtering logs, we don't lose the second one.
There was a problem hiding this comment.
So if our log range start is based on the last block, then it's from lastBlock -> end instead of lastBlock + 1 -> end
There was a problem hiding this comment.
In practical terms this doesn't happen to us, but it is a fix overall now that we can detect duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using simple block logic to skip possibly duplicate blocks. This is enough for our uses, since the log rate for the events should be 1 per block at most in a real scenario, but it's not a full solution. This PR introduces an LRU cache of log hashes (defined by ourselves) that is used to detect whether a log has been relayed yet or not. It also makes it so our log filtering starts from the last block, since we now can detect duplicate blocks - so if, e.g. there were 2 block emissions on
lastBlockand we'd only gotten 1 before filtering logs, we don't lose the second one.