Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator initialization metric to aggregator #177

Merged
merged 8 commits into from
May 24, 2024
Merged

Conversation

Hyodar
Copy link
Contributor

@Hyodar Hyodar commented May 23, 2024

Adds a simple metric to track operator initializations in aggregator. The idea here is not that we strictly need to know that operator X has initialized, but at least have some kind of ping so we can detect crashes if they happen.

@Hyodar Hyodar requested review from emlautarom1 and taco-paco May 23, 2024 00:52
@Hyodar Hyodar self-assigned this May 23, 2024
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't see anything worth mentioning except for the usage of logger.Errof instead of logger.Error with tags (I'm not sure if there's an agreement on what to use)

@Hyodar
Copy link
Contributor Author

Hyodar commented May 24, 2024

Oh well. Yeah, we've not settled on one specifically, but we've been trying to use Error + tag "err". I see there are multiple places in metrics that the format one is used, so I don't think this is work for this PR. Added an issue for that: #179.

@Hyodar Hyodar merged commit 290b361 into main May 24, 2024
4 checks passed
@Hyodar Hyodar deleted the feat/op-reinit-metrics branch October 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants