New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state root update messaging to aggregator and operator #12

Merged

Hyodar merged 29 commits into main from feat/node/state-root-updates

Feb 6, 2024

Contributor

Hyodar commented Feb 1, 2024

No description provided.

Hyodar self-assigned this

Hyodar force-pushed the feat/node/state-root-updates branch 2 times, most recently from 2a7cf79 to 65e1d21 Compare

February 2, 2024 02:42

Hyodar changed the title ~~Add state root upate messaging to aggregator and operator~~ Add state root update messaging to aggregator and operator

Hyodar force-pushed the feat/node/state-root-updates branch from a343e86 to c30be4f Compare

February 2, 2024 14:05

Hyodar marked this pull request as ready for review

February 4, 2024 19:26

Hyodar requested a review from taco-paco

February 5, 2024 00:55

taco-paco reviewed

View reviewed changes

aggregator/database.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/database.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/message_blsagg.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/aggregator.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/aggregator.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/rpc_server.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/rpc_server.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/rpc_server.go Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/message_blsagg.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/message_blsagg.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/message_blsagg.go Outdated Show resolved Hide resolved

taco-paco suggested changes

View reviewed changes

Contributor

taco-paco left a comment

Some of comments are just my perception of how things shall be but there're some that requires your attention. Especially InitializeNewMessage and ProcessSignedStateRootUpdateMessage

taco-paco reviewed

View reviewed changes

operator/rpc_client.go Outdated Show resolved Hide resolved

taco-paco reviewed

View reviewed changes

aggregator/rpc_server.go Outdated Show resolved Hide resolved

Hyodar requested a review from taco-paco

February 6, 2024 13:47

taco-paco approved these changes

View reviewed changes

Contributor

taco-paco left a comment

Looks great

Hyodar added 7 commits

February 6, 2024 16:34


          feat: Process state root message signatures on aggregator

096a578


          feat: Add REST API and persistently store aggregated messages


          test: Add new config fields to integration test

256fe72


          refactor: Rename REST handler

4f1c8ce


          feat: Change REST route to aggregation/state-root-update

9042f6c


          refactor: Refactor message BLS response handling

cb193ac


          refactor: Move MessageBlsAggregationServiceResponse to aggregator/types

2f565e1

Hyodar added 21 commits

February 6, 2024 16:34


          test: Generate message_blsagg mock

8af701f


          feat: Add allowAlreadyInitialized flag to InitializeNewMessage

6d15da8


          feat: Initialize in-memory DB if databasePath is empty

d897e88


          test: Add state root update message submission test

7c3a1e7


          feat: Add state root update message sending to operator RPC client

e69142f


          feat: Add messages received and signed messages accepted counter metrics

ae1d6a9


          fix: Clean up memory after bls service response

24ed2ee


          refactor: Add message TTL as const to types and change it to 1 minute

cabc2d7


          refactor: Move database implementation to MessageDatabase

685f3d0


          fix: Consider ProcessNewSignature errors before storing messages in R…

6a57544

…PC calls


          refactor: Refactor signed message digest handling

14ff93a


          refactor: Return early from handleSignedMessageDigest on a sig verifi…

db0090e

…cation error


          fix: Fix message double initialization

d82345d


          refactor: Remove retryCount RPC sendRequest callback

e1b08e0


          refactor: Refactor InitializeNewMessage into InitializeMessageIfNotEx…

b56f934

…ists


          refactor: Standardize type abbreviations

79074cf


          refactor: Standardize mutexes naming to *Lock

0edd384


          feat: Add SendSignedStateRootUpdateToAggregator to AggregatorRpcClienter

8874f39


          feat: Send signed state root update to aggregator on new block

43025f6


          feat: Replace messages nearBlockHeight with timestamp

13b1bed


          test: Include state root message sending on operator test

0d756bb

Hyodar force-pushed the feat/node/state-root-updates branch from 8217a48 to 0d756bb Compare

February 6, 2024 20:05


          feat: Close operator consumer when context is cancelled

595cdeb

Hyodar force-pushed the feat/node/state-root-updates branch from 39bbaf9 to 595cdeb Compare

February 6, 2024 20:12

Hyodar merged commit a9783f3 into main

3 checks passed

Hyodar mentioned this pull request

Add OperatorSetUpdateMessage support to aggregator and operator #17

Merged

Hyodar mentioned this pull request

Clean config #33

Merged

emlautarom1 mentioned this pull request

Include signature in message receiving logs #264

Merged

Hyodar deleted the feat/node/state-root-updates branch

July 22, 2024 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet