-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumer #11
Consumer #11
Conversation
Block stream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor observations mainly. I'd like to take a look again after those are discussed, so marking it accordingly.
…tionality into Consumer
Okay, I ended up doing more changes than I initially expected, so I'll still leave the PR open for you to take a look tomorrow. Feel free to revert whatever, but I think mostly it's not something that will bring much of a discussion. Breaking down the most significant changes a bit so it's easier to consider:
There were also some minor changes, some related to my private comments on Slack. |
Made some other small changes and integrated the consumer into the operator. I was originally going to do this in my PR after this was merged, but decided to do this instead. Same observations as above, feel free to do whatever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.