This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Dataset import lock #20
Open
ziodave
wants to merge
29
commits into
NuCivic:7.x-1.x
Choose a base branch
from
ziodave:dataset_import_lock
base: 7.x-1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e *page* parameter has been removed)
…e *page* parameter has been removed)
…s) to enable superclasses to override it
…that can't support it
…only if available
…migrate process not to import the dataset
We will keep this PR open but have not prioritized it. Among other things, the multiple processes needed are not available in all environments - notably, Pantheon. Still a compelling improvement that we will try to revisit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
After migrating data from CKAN, editors update the dataset metadata with additional data or editing the existing data, which eventually gets overwritten by a subsequent import.
I have been ask therefore to support a migrate lock flag which tells the migrate procedure not to import the dataset.
This PR provides support for this (optional) field. If the field doesn't exist, is not set, or is set to something different than 1 then the dataset is imported as usual, otherwise the import is skipped.
Resources for a dataset are always imported.