Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup and handle small issues #124

Merged
merged 32 commits into from
Dec 17, 2024
Merged

feat: cleanup and handle small issues #124

merged 32 commits into from
Dec 17, 2024

Conversation

akselthomsen
Copy link
Contributor

@akselthomsen akselthomsen commented Dec 9, 2024 •
edited
Loading

Small cleanup of some easy to handle issues #77 & #62 enabling the user to:

  1. Use R expressions in the _whirl.yml config file
  2. Use a costum execute directory for the Quarto process running each script by using the execute_dir option

Lovemore-Gakava and others added 3 commits December 2, 2024 13:52
@Lovemore-Gakava
Update dummy.qmd
fc341be 
session info to show python packages for if python scripts have been executed.

Signed-off-by: Lovemore Gakava <[email protected]>
fix - reinstate python_packages <- NULL to carter for cases when a no…
4e38621 
…n python script is run.
@akselthomsen
feat: #77 evaluate expressions in yaml
d572ffe
@akselthomsen akselthomsen changed the title feat: #77 evaluate expressions in yaml feat: cleanup and handle small issues Dec 9, 2024
@akselthomsen akselthomsen linked an issue Dec 9, 2024 that may be closed by this pull request
feat: if using a expression in yaml file for config, Pass the param eval.expr = TRUE for whirl #77
Closed
@akselthomsen
ci: debug
e698bf1
@akselthomsen
fix
28a73fa
@akselthomsen
debug: quarto check
6dbf08d
@akselthomsen
debug
c3d48cb
@akselthomsen
debug ci
7d6d63a
@akselthomsen
ci test
9c265ed
@akselthomsen
debug
4b761ca
@akselthomsen
debug
e021ab6
@akselthomsen
debug
e0669af
@akselthomsen
debug
bb82270
@akselthomsen
Update action.yaml
8c3397c 
Signed-off-by: Aksel Thomsen <[email protected]>
@akselthomsen
Update action.yaml
1ecb6b8 
Signed-off-by: Aksel Thomsen <[email protected]>
@akselthomsen
bugfix: handle no installed python packages
a38b6e9
@akselthomsen
test: always get python version
2b1082d
@akselthomsen
fix: empty table when using python with no imports
f6bee4f
@akselthomsen
fix: remove line
7cf96d6
@akselthomsen
ci: back to original workflows
3089693
@akselthomsen
chore: cleanup test stuff
e1a7951
@akselthomsen
merge with main
76af05c 
Merge branch 'main' into session-info-py-patch-1
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@akselthomsen
update version and news
ca3bf17
@akselthomsen
Delete .lintr
e7cbe93 
Signed-off-by: Aksel Thomsen <[email protected]>
@akselthomsen
fix: linting
49db4eb
@akselthomsen
merge main
622714e 
Merge branch 'main' into feat/issue-cleanup
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@akselthomsen akselthomsen linked an issue Dec 13, 2024 that may be closed by this pull request
feat: Give you the option of running R scripts in the folder in which they are stored. #62
Closed
@akselthomsen akselthomsen mentioned this pull request Dec 13, 2024
Closed
@akselthomsen akselthomsen marked this pull request as ready for review December 17, 2024 10:16
@akselthomsen
feat: bump version for next release
5290814 
Merge branch 'session-info-py-patch-1' into feat/issue-cleanup
@akselthomsen
update news
3b21916
@akselthomsen
fix: typo
98da3c5
@github-actions GitHub Actions
Copy link

Code coverage

Name Coverage (%)
whirl 61.25
R/approvedpkgs.R 0.00
R/custom_logging.R 63.04
R/enrich_input.R 100.00
R/internal_run.R 100.00
R/mdformats.R 0.00
R/normalize_with_base.R 100.00
R/pb_script.R 0.00
R/quarto.R 100.00
R/read_glob.R 100.00
R/render_summary.R 94.12
R/renv.R 0.00
R/run.R 92.16
R/session.R 78.53
R/status.R 100.00
R/strace.R 0.00
R/use_whirl.R 100.00
R/util_queue_summary.R 100.00
R/utils.R 65.85
R/whirl_queue.R 93.65
R/whirl_r_session.R 77.40
R/zzz.R 0.00

@github-actions GitHub Actions
Copy link

Github pages

Review the pkgdown webpage for the PR here

Cervangirard
Cervangirard approved these changes Dec 17, 2024
View reviewed changes
Copy link

@Cervangirard Cervangirard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but with a few comments, it's up to you to decide whether they make sense or not.

R/whirl_r_session.R Show resolved Hide resolved
tests/testthat/test-run.R Show resolved Hide resolved
R/whirl_r_session.R Show resolved Hide resolved
@akselthomsen akselthomsen merged commit 1237976 into main Dec 17, 2024
13 of 14 checks passed
@akselthomsen akselthomsen deleted the feat/issue-cleanup branch December 17, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cervangirard Cervangirard Cervangirard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akselthomsen @Cervangirard @Lovemore-Gakava