Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/log folder #123

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Feat/log folder #123

merged 12 commits into from
Dec 10, 2024

Conversation

Troejelsgaard
Copy link
Contributor

Enable redirection of logs through log_dir argument in run()

NNktqn added 5 commits December 5, 2024 10:53
@NNktqn
Correcting small typo
8e36c76
@NNktqn
Enable redirection of logs through log_dir argument in run()
b633fd6
@NNktqn
Updating test for the new log_dir argument
a6d2617
@NNktqn
Updating documentations
07c96f2
@NNktqn
Merge with main
2807ed2 
Merge branch 'main' into feat/log_folder
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@akselthomsen akselthomsen linked an issue Dec 9, 2024 that may be closed by this pull request
feat: Allow users to specify where the log(s) should be stored #79
Closed
@akselthomsen akselthomsen self-requested a review December 9, 2024 12:56
akselthomsen
akselthomsen reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@akselthomsen akselthomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is very good :)
I have some small suggested changes, that I opened a PR with if you want to accept them (#125 )

vignettes/whirl.Rmd Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Github pages

Review the pkgdown webpage for the PR here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Code coverage

Name Coverage (%)
whirl 60.27
R/approvedpkgs.R 0.00
R/custom_logging.R 63.04
R/enrich_input.R 100.00
R/internal_run.R 100.00
R/mdformats.R 0.00
R/normalize_with_base.R 100.00
R/pb_script.R 0.00
R/quarto.R 100.00
R/read_glob.R 100.00
R/render_summary.R 94.12
R/renv.R 0.00
R/run.R 92.16
R/session.R 73.55
R/status.R 100.00
R/strace.R 0.00
R/use_whirl.R 100.00
R/util_queue_summary.R 100.00
R/utils.R 65.85
R/whirl_queue.R 93.65
R/whirl_r_session.R 76.62
R/zzz.R 0.00

@Troejelsgaard Troejelsgaard merged commit fb74093 into main Dec 10, 2024
13 of 14 checks passed
@Troejelsgaard Troejelsgaard deleted the feat/log_folder branch December 10, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akselthomsen akselthomsen akselthomsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Allow users to specify where the log(s) should be stored
3 participants
@Troejelsgaard @akselthomsen @NNktqn