Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing hyperlink bug and adjust title of individual logs #122

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Fixing hyperlink bug and adjust title of individual logs #122

merged 7 commits into from
Dec 6, 2024

Conversation

Troejelsgaard
Copy link
Contributor

Fixing bug in the hyperlink in the summary file and adjust title to basename in the individual logs
#111

@akselthomsen akselthomsen self-requested a review December 5, 2024 10:09
@akselthomsen akselthomsen linked an issue Dec 6, 2024 that may be closed by this pull request
feat: split title of html log into name and subtitle be the path of script #111
Closed
akselthomsen
akselthomsen requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@akselthomsen akselthomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good :)

inst/documents/title-block.html Outdated Show resolved Hide resolved
R/internal_run.R Outdated Show resolved Hide resolved
falgreen
falgreen approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@falgreen falgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Github pages

Review the pkgdown webpage for the PR here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Code coverage

Name Coverage (%)
whirl 59.87
R/approvedpkgs.R 0.00
R/custom_logging.R 63.04
R/enrich_input.R 100.00
R/internal_run.R 100.00
R/mdformats.R 0.00
R/normalize_with_base.R 100.00
R/pb_script.R 0.00
R/quarto.R 100.00
R/read_glob.R 100.00
R/render_summary.R 94.12
R/renv.R 0.00
R/run.R 92.00
R/session.R 73.55
R/status.R 100.00
R/strace.R 0.00
R/use_whirl.R 100.00
R/util_queue_summary.R 100.00
R/utils.R 63.41
R/whirl_queue.R 95.54
R/whirl_r_session.R 76.38
R/zzz.R 0.00

@Troejelsgaard Troejelsgaard merged commit 9758418 into main Dec 6, 2024
13 of 14 checks passed
@Troejelsgaard Troejelsgaard deleted the fix/render_summary branch December 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akselthomsen akselthomsen akselthomsen approved these changes

@falgreen falgreen falgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: split title of html log into name and subtitle be the path of script
4 participants
@Troejelsgaard @falgreen @akselthomsen @NNktqn