-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bug when a config only points to other config files and Switch to using simple glob instead of regexp #119
Conversation
Merge branch 'main' into feat_redirect_logs # Conflicts: # R/read_glob.R
Merge branch 'main' into feat_redirect_logs # Conflicts: # NEWS.md # R/internal_run.R # inst/examples/demo/config_to_config.yaml # inst/examples/demo/demo_2_whirl.yml # inst/examples/demo/demo_skip_whirl.yaml # inst/examples/demo/demo_whirl.yaml # tests/testthat/test-read_regexp.R
Github pagesReview the pkgdown webpage for the PR here |
Code coverage
|
@Troejelsgaard and @akselthomsen thanks for the PR! Checked: Added support for logging of Python scripts with run(). General: when a wildcard is used to run scripts in a folder, run (tries) to execute all the files in that folder regardless of file format. Lets restrict it to suported files (R, Rmd, Py, qmd) |
(1) Fixing a bug that happens when a config only points to other config files, and (2) Switch to using simple glob instead of regexp (ignore the weird branch name that has nothing to do with was actually done)
First, the pull request fixes a bug where the queue was not returned correctly when a config files only points to other config files.
Secondly, the use of
glob2rx()
had some strange behaviours when trying to point to files with different extensions for example r vs R. For example when using "program.r|R" all R files in the folder was found and when using "program.[rR]" the "[" was not translated correctly.Therefore, instead of using
glob2rx()
the code now only usesSys.glob()
The programread_regexp()
has as consequence been renamed toread_glob()
(and so has the function within this program)