-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add md ds to connectors #55
Conversation
give the opportunity to recreate the config from a connectors object
Signed-off-by: Cervangirard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionalities look ok. I just think we need to stay consistent when definin imports from packages in documentation. I had few other comments. Also don't know if we should enforce parameter checking in internal functions (at least checkmate). All in all it looks good.
Code coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now's good.
Add the possibility to store the datasources object inside a connectors :
Main changes are :
How to test :