-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save multiple LED's as separate spatialSeries within position #557
Open
samuelbray32
wants to merge
239
commits into
NovelaNeuro:master
Choose a base branch
from
samuelbray32:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put position closer to beginning
these lines are duplicates of preceding lines 268, 274 & 290. they were trying to create keys that already exist, raising errors.
that was missing in the latest update
Fix originator errors
previously one would get error at write time, only after contents are built (which takes a while)
…comparison Fix default header comparison
* add new attribute preprocessing_path in builders * copy xml headers to the preprocessing path, if specified the preprocessing path can be different from raw data path * pass preprocessing_path to extract_trodes_rec_file so that preprocessed binaries are saved to preprocessing_path. this depends on rec_to_binaries update (pending pull request at the moment) * pass dates to preprocess selectively * fix dependency: require rec-to-binaries updated version
…' into process-kf2-no-timestamps
no change to existing user interface
- allow separate preprocessing_path - reorder video files originator in build()
- use a dummy default value for session_start_time
numpy array required
- timestamps are not available in this case; fill with dummy values
- timestamps file should be treated differently - should add timestamp conversion in future updates
(required method retrieve_real_timestamps)
…s final column names
Co-authored-by: Eric Denovellis <[email protected]>
save multiple LED position data as separate spatialSeries
closes issue LorenFrankLab#53
…_overlap Fix analog name overlap
…erlap Fix error caused by Controller_Din headstage channels
Fix f-string bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conforms to NWB formatting guidelines which expect at most 3 spatial dimensions on each object. The naming convention for the spatial series becomes:
led_{}_series_{}