Resolve #544 : refactor RawToNWBBuilder for easier workflow #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunbak
changed the title
jihyunbak
force-pushed
the
refactor-raw-to-nwb-builder
branch
from
6cdd317 to
ab5a682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #544 for me.
After constructing a RawToNWBBuilder,
User-developer can now run the NWB builder part separately. Kept this a private function to match with the existing method
__preprocess_data(). Ideally this separation is not needed if everything "just works".User can also extract a matching NWBFileBuilder for a specific day: