Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos in the vignette #4

Open
wants to merge 8 commits into
base: devel
Choose a base branch
from

Conversation

csoneson
Copy link

@csoneson csoneson commented Sep 14, 2024

Hi @MarkusMuck - out of curiosity I was reading through the vignette and found a few typos 🙂

In addition:

  • it looks like the score filtering doesn't do anything in the example data (all scores are above 10):
    #### Filter for enrichment value
  • should this refer to a specific section (not "Relevant Section")?
    If you can’t provide data for the optional columns, prepare_input_regions adds sensible defaults for you (see “Relevant Section”).
  • it may be good to check if you really need all the packages that are currently listed in Imports/Suggests - e.g., is tidyverse really needed (or are the individual components enough), are devtools, lintr, styler and usethis needed by the user (also utils does not seem to be used)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant