Process OF messages spanning multiple TCP segments #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'size' is really the offset into 'packetbuffer', while 'len' is the amount of data in 'packetbuffer'. 'plen' is the OF packet length. Ideally OF message processing routines should only care about the data for the specific message they are processing, and do not need to know the offset within 'packetbuffer' or the amount of data in 'packetbuffer'.
A single OFPT13_MULTIPART_REQUEST will be for a single type, so there is no need to retain state over multiple invokations of of13_message(). Also, all OFPT13_MULTIPART_RESPONSE can be sent at the end of the REQUEST processing. Handling OFPT13_MULTIPART_REQUEST this way will all for the removal of the final global data from of_receive() processing.
TCP provides a stream of bytes (it does not preserve transmitter framing / messages), so it is possible for a single OpenFlow message to be delivered in multiple TCP segments. of_receive needs to cater for this operation.
|
Will be applied to dev repo (pzanna:Dev_86) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft patch sequence to address #84. 2 of the patches are pre-cursors for the work of the 3rd patch.
NOTE: I've only managed to compile this patch sequence (Linux Makefiles) - but I have not been able to test it on a ZodiacFX (see #76). Can someone please build / test this patch using the official toolchain before committing it.