Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: reduce severaty of battery dicsonnect event while profiling #155

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Feat: reduce severaty of battery dicsonnect event while profiling #155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3e23f2
Feat: reduce severaty of battery dicsonnect event while profiling
kylebonnici Apr 2, 2024
4f1c549
Update Changelog.md
kylebonnici Apr 3, 2024
ae13898
Fix: lint
kylebonnici Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
### Changed

- Updated firmware to v1.1.1+0.
- Disconnected battery (vBat < 1V) while profiling this will only trigger a
warning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand this sentence.

kylebonnici marked this conversation as resolved.
Show resolved Hide resolved

### Removed

Expand Down
3 changes: 2 additions & 1 deletion src/components/Profiling/Dialog/ProfilingWizard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ export default () => {
npmDevice?.getBatteryProfiler()?.stopProfiling();
dispatch(
setCompleteStep({
level: 'danger',
level:
profilingStage === 'Resting' ? 'danger' : 'warning',
message: ` The profiling process was interrupted, as battery was disconnected while ${profilingStage}.`,
})
);
Expand Down
Loading