Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OsirisExtenderSettings.json documentation #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PinewoodPip
Copy link
Contributor

This PR adds some missing settings to the table in the readme, shows the default values for all settings, and fixes some inconsistencies in wording ("Enable ..." vs "Enables ...").

DumpNetworkStrings setting was omited as it is currently non-functional and will possibly be removed (discussed in DMs).

The default values mentioned are for a release build. It might be worth noting that some differ on a debug build?

@Lightsockie
Copy link

(Just some suggestions)
Would be killer to add where the file is even supposed to be located imo (and maybe even a template). Trying to enable logging now to trace a CTD and it's proving oddly frustratingly difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants