Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the authentication URL regexp for Auth0 provider #475

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

maintux
Copy link
Contributor

@maintux maintux commented Sep 26, 2023

Changelog

  • authentication URL regexp for Auth0 provider

Bugfixes

At the moment, the regexp used to check if the URL is an authentication URL for Auth0 checks if /samlp is in the URL. The correct one instead checks if /u/login is present.
This misconfiguration causes the opening of the login modal window for every credential refresh process because the needAuthentication method always resolves with true.

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Giaco9
Copy link

Giaco9 commented Oct 5, 2023

Hi everyone,
do you have any timeline for releasing this? I'm currently using Auth0 as an identity provider, and the bug this PR would solve is really annoying. I checked the pull-request #321, and it has the same failed check about "Incomplete regular expression for hostnames", but has been merged without a fix. Maybe @rick-rtt could help also this time? If needed I can help in testing this :)

Thank you again @maintux and the Leapp team, as #321 this pull-request would really helpful for me :)

@andreacavagna01
Copy link
Contributor

We are going to release this feature this week! thanks for the support guys!

@urz9999 urz9999 merged commit a8b4e35 into Noovolari:master Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants