chore(jenkins): get job name from constants

Nookure · Dec 28, 2024 · 496c26e · 496c26e
1 parent cdd7e00
commit 496c26e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/NookureStaff-API/src/main/java-templates/com/nookure/staff/Constants.java.peb b/NookureStaff-API/src/main/java-templates/com/nookure/staff/Constants.java.peb
@@ -13,5 +13,7 @@ public final class Constants {
   public static final String JENKINS_BUILD_ID = "{{ jenkinsBuildId }}";
   public static final String JENKINS_BUILD_URL = "{{ jenkinsBuildUrl }}";
 
+  public static final String JENKINS_JOB_NAME = "NookureStaff";
+
 	private Constants() {}
 }
diff --git a/NookureStaff-API/src/test/java/com/nookure/staff/api/jenkins/JenkinsTest.java b/NookureStaff-API/src/test/java/com/nookure/staff/api/jenkins/JenkinsTest.java
@@ -1,5 +1,6 @@
 package com.nookure.staff.api.jenkins;
 
+import com.nookure.staff.Constants;
 import com.nookure.staff.api.jenkins.json.JenkinsJob;
 import com.nookure.staff.api.jenkins.json.JenkinsRun;
 import org.junit.jupiter.api.Test;
@@ -19,8 +20,8 @@ public void testGetJob() {
   @Test
   @EnabledIf("canRun")
   public void testGetRun() {
-    final JenkinsJob jenkinsJob = jenkinsBaseClient.getJob("NookureStaff").join();
-    final JenkinsRun jenkinsRun = jenkinsBaseClient.getRun("NookureStaff", jenkinsJob.lastCompletedBuild().number()).join();
+    final JenkinsJob jenkinsJob = jenkinsBaseClient.getJob(Constants.JENKINS_JOB_NAME).join();
+    final JenkinsRun jenkinsRun = jenkinsBaseClient.getRun(jenkinsJob, jenkinsJob.lastCompletedBuild().number()).join();
 
     assert jenkinsRun != null;
   }

diff --git a/NookureStaff-Paper/src/main/java/com/nookure/staff/paper/bootstrap/StaffBootstrapper.java b/NookureStaff-Paper/src/main/java/com/nookure/staff/paper/bootstrap/StaffBootstrapper.java
@@ -91,7 +91,7 @@ public void checkVersion() {
 
     JenkinsBaseClient jenkinsBaseClient = new JenkinsBaseClient(JENKINS_URL);
 
-    jenkinsBaseClient.getJob("NookureStaff").thenAccept(jenkinsJob -> {
+    jenkinsBaseClient.getJob(Constants.JENKINS_JOB_NAME).thenAccept(jenkinsJob -> {
       if (jenkinsJob == null) {
         getLogger().warning("Couldn't get the latest version from Jenkins.");
         return;