always reduce connection count when force disconnecting #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't see any reason for that check on `self.max_connections_per_node` given that `count_all_num_connections` sums over all node connections when `count_all_num_connections == False`. I was quickly running into the MaxConnections error when a single node was likely slow in it's response. I was wondering why it went away when I experimented with setting `max_connections_per_node` in the config.
|
Hi @eoghanmurray -- just wanted to let you know that my org has recently forked Wanted to especially thank you for your work here -- we've been running into a leaking connection issue for ages on aredis and that's one of the major things which prompted us to start maintaining a fork. Seeing that long-standing issue get resolved as soon as I merged in this PR was fantastic and is going to save me from so many pagerdutys! |
alisaifee
added a commit
to alisaifee/coredis
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see any reason for that check on
self.max_connections_per_nodegiven thatcount_all_num_connectionssums over all node connections whenmax_connections_per_node == False.I was quickly running into the MaxConnections error when a single node was likely slow in it's response. I was wondering why it went away when I experimented with setting
max_connections_per_nodein the config.