Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BlockingConnectionPool #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sileht
Copy link

@sileht sileht commented Mar 25, 2021

Description

Add support for BlockingConnectionPool.

@TheKevJames
Copy link
Contributor

Hi @sileht -- just wanted to let you know that my org has recently forked aredis as it appears to have become unmaintained and we've merged in this pull request (and all other open PRs against the aredis repo); in case you find it useful, the fork is here and version 2.0.0 is on PyPI with your changes.

I tweaked this change a bit by making get_connection() an awaitable in all cases, since we were planning on a hard fork and a major (breaking) version bump anyway, but otherwise left things pretty much as is since it worked perfectly for all the test cases I could think to throw at it.

alisaifee added a commit to alisaifee/coredis that referenced this pull request Jan 17, 2022
alisaifee added a commit to alisaifee/coredis that referenced this pull request Jan 17, 2022
alisaifee added a commit to alisaifee/coredis that referenced this pull request Jan 17, 2022
alisaifee added a commit to alisaifee/coredis that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants