Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pipeline behaviour to execute all commands at the end of the block #168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eoghanmurray
Copy link
Contributor

(the behaviour I expected)

@eoghanmurray eoghanmurray changed the title Change pipeline behaviour to execute all commands at the end of thelock Change pipeline behaviour to execute all commands at the end of the block Aug 19, 2020
Copy link
Contributor

@Fogapod Fogapod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about mentioning this in documentation and fixing examples?
Having a test for this would also be nice.

Also in redis-py only reset is called, creating slightly different behavior.

@eoghanmurray
Copy link
Contributor Author

Thanks @Fogapod I've made the minimal set of changes to the docs and added a test case.

I've raised a similar issue in redis-py to see if there are any objections there:
redis/redis-py#1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants