Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-locate parser generator logic #972

Merged
merged 7 commits into from
May 22, 2024

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented May 21, 2024

Part of #638, removes the codegen_grammar crate

Instead of having the definitions and the parser generation separate, we now co-locate this and provide a parser-specific model (for MVC rendering introduced in #962) for the code generation. This mostly moves code around and documents a bit more what we already have.

This is fairly non-controversial and I am for #638 to be incremental, so this is meant to progress the issue rather than fix it in one giant PR to keep up the velocity and land it as soon as possible, accounting for my upcoming move to Hardhat soon. If this generally makes sense, I'd love to have a rubber stamp for it; for now, I'll work on top of this to further migrate off DSLv1 definitions.

@Xanewok Xanewok requested a review from a team as a code owner May 21, 2024 19:05
Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: 501b602

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Xanewok Xanewok added this pull request to the merge queue May 22, 2024
Merged via the queue into NomicFoundation:main with commit d1b348e May 22, 2024
1 check passed
@Xanewok Xanewok deleted the co-locate-parser-generator branch May 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants