Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate EBNF codegen to DSL v2 #734

Merged

Conversation

OmarTawfik
Copy link
Contributor

leaving the older ebnf codegen in place until codegen_spec is migrated as well.

Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: c45b81e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik force-pushed the migrate-ebnf-to-dsl-v2 branch from 9360a43 to bc2a121 Compare January 9, 2024 17:41
@OmarTawfik OmarTawfik marked this pull request as ready for review January 9, 2024 17:45
@OmarTawfik OmarTawfik requested a review from a team as a code owner January 9, 2024 17:45
@OmarTawfik OmarTawfik enabled auto-merge January 9, 2024 17:51
@OmarTawfik OmarTawfik disabled auto-merge January 9, 2024 17:52
@OmarTawfik OmarTawfik enabled auto-merge January 10, 2024 11:51
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some readability nitpicks in builder.rs that I'd like to see addressed, if you don't mind 🙏

crates/codegen/ebnf/src/builder.rs Show resolved Hide resolved
crates/codegen/ebnf/src/builder.rs Outdated Show resolved Hide resolved
crates/codegen/ebnf/src/builder.rs Outdated Show resolved Hide resolved
crates/solidity/outputs/spec/build.rs Outdated Show resolved Hide resolved
crates/solidity/outputs/spec/build.rs Outdated Show resolved Hide resolved
crates/solidity/outputs/spec/build.rs Outdated Show resolved Hide resolved
crates/codegen/ebnf/src/serializer.rs Outdated Show resolved Hide resolved
@OmarTawfik OmarTawfik force-pushed the migrate-ebnf-to-dsl-v2 branch from bc2a121 to c647cb7 Compare January 10, 2024 16:08
@OmarTawfik OmarTawfik requested a review from Xanewok January 10, 2024 16:09
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused by the SimpleEbnfWriter and didn't mean to block you on minor stuff. I'm approving not to induce churn - feel free to either re-add it to the queue or make the helper enums Copy to reduce some of the sigils in call-sites.

crates/codegen/ebnf/src/builder.rs Show resolved Hide resolved
crates/solidity/outputs/spec/build.rs Outdated Show resolved Hide resolved
@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 10, 2024
@Xanewok Xanewok removed this pull request from the merge queue due to a manual request Jan 10, 2024
@OmarTawfik OmarTawfik force-pushed the migrate-ebnf-to-dsl-v2 branch from fc0612c to 049ceaf Compare January 11, 2024 07:39
@OmarTawfik OmarTawfik enabled auto-merge January 11, 2024 07:39
@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 11, 2024
Merged via the queue into NomicFoundation:main with commit 4795e97 Jan 11, 2024
1 check passed
@OmarTawfik OmarTawfik deleted the migrate-ebnf-to-dsl-v2 branch January 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants