-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate EBNF codegen to DSL v2 #734
migrate EBNF codegen to DSL v2 #734
Conversation
|
9360a43
to
bc2a121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have some readability nitpicks in builder.rs that I'd like to see addressed, if you don't mind 🙏
bc2a121
to
c647cb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused by the SimpleEbnfWriter
and didn't mean to block you on minor stuff. I'm approving not to induce churn - feel free to either re-add it to the queue or make the helper enums Copy to reduce some of the sigils in call-sites.
fc0612c
to
049ceaf
Compare
leaving the older ebnf codegen in place until
codegen_spec
is migrated as well.